test: use Countdown in http-agent test

PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
nodejs · Dec 20, 2017 · 2f92fad · 2f92fad
1 parent 2282fd0
commit 2f92fad
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/test/parallel/test-http-agent.js b/test/parallel/test-http-agent.js
@@ -21,6 +21,7 @@
 
 'use strict';
 const common = require('../common');
+const Countdown = require('../common/countdown');
 const assert = require('assert');
 const http = require('http');
 common.crashOnUnhandledRejection();
@@ -33,14 +34,17 @@ const server = http.Server(common.mustCall(function(req, res) {
 }, (N * M))); // N * M = good requests (the errors will not be counted)
 
 function makeRequests(outCount, inCount, shouldFail) {
-  let responseCount = outCount * inCount;
+  const countdown = new Countdown(
+    outCount * inCount,
+    common.mustCall(() => server.close())
+  );
   let onRequest = common.mustNotCall(); // Temporary
   const p = new Promise((resolve) => {
     onRequest = common.mustCall((res) => {
-      if (--responseCount === 0) {
-        server.close();
+      if (countdown.dec() === 0) {
         resolve();
       }
+
       if (!shouldFail)
         res.resume();
     }, outCount * inCount);