Skip to content

Commit

Permalink
deps: V8: backport df5724c11697b4fbe803adcb5a51020dea2d923f
Browse files Browse the repository at this point in the history
  • Loading branch information
richardlau committed May 1, 2024
1 parent 8f37492 commit 2c30d3d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/compiler/turboshaft/index.h
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ class ConstOrV {
template <typename U,
typename = std::enable_if_t<std::is_constructible_v<V<T>, V<U>>>>
ConstOrV(V<U> index) // NOLINT(runtime/explicit)
: constant_value_(), value_(index) {}
: constant_value_(std::nullopt), value_(index) {}

bool is_constant() const { return constant_value_.has_value(); }
constant_type constant_value() const {
Expand Down

0 comments on commit 2c30d3d

Please sign in to comment.