squash! squash! src: aquire mutex lock in ManagedEVPPKey::operator=

Fix linter issues.
nodejs · Mar 10, 2021 · 28f2c9b · 28f2c9b
1 parent e11f03f
commit 28f2c9b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/crypto/crypto_ec.cc b/src/crypto/crypto_ec.cc
@@ -925,7 +925,7 @@ Maybe<bool> GetEcKeyDetail(
 // implementation here is a adapted from Chromium's impl here:
 // https://github.com/chromium/chromium/blob/7af6cfd/components/webcrypto/algorithms/ecdsa.cc
 
-size_t GroupOrderSize(ManagedEVPPKey& key) {
+size_t GroupOrderSize(const ManagedEVPPKey& key) {
   const EC_KEY* ec = EVP_PKEY_get0_EC_KEY(key.get());
   CHECK_NOT_NULL(ec);
   const EC_GROUP* group = EC_KEY_get0_group(ec);
@@ -935,7 +935,7 @@ size_t GroupOrderSize(ManagedEVPPKey& key) {
 }
 
 ByteSource ConvertToWebCryptoSignature(
-    ManagedEVPPKey& key,
+    const ManagedEVPPKey& key,
     const ByteSource& signature) {
   const unsigned char* data =
       reinterpret_cast<const unsigned char*>(signature.get());
@@ -961,7 +961,7 @@ ByteSource ConvertToWebCryptoSignature(
 }
 
 ByteSource ConvertFromWebCryptoSignature(
-    ManagedEVPPKey& key,
+    const ManagedEVPPKey& key,
     const ByteSource& signature) {
   size_t order_size_bytes = GroupOrderSize(key);
 

diff --git a/src/crypto/crypto_ec.h b/src/crypto/crypto_ec.h
@@ -164,11 +164,11 @@ v8::Maybe<bool> GetEcKeyDetail(
     v8::Local<v8::Object> target);
 
 ByteSource ConvertToWebCryptoSignature(
-  ManagedEVPPKey& key,
+  const ManagedEVPPKey& key,
   const ByteSource& signature);
 
 ByteSource ConvertFromWebCryptoSignature(
-    ManagedEVPPKey& key,
+    const ManagedEVPPKey& key,
     const ByteSource& signature);
 
 }  // namespace crypto