Skip to content

Commit

Permalink
test: remove test case 0 from tls-cnnic-whitelist
Browse files Browse the repository at this point in the history
I looks like this test has not worked as expected since commit
2bc7841 ("test: use random ports
where possible"). The test in that commit checked for `CERT_REVOKED`
which was returned by CheckWhitelistedServerCert.

CheckWhitelistedServerCert was later removed in commit
dc87543 ("src: drop CNNIC+StartCom
certificate whitelisting").

I'm suggesting that this test case be removed as I don't think it is
valid anymore.

PR-URL: #19767
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
danbev authored and jasnell committed Apr 14, 2018
1 parent 7a33c2c commit 1d72434
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions test/parallel/test-tls-cnnic-whitelist.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,6 @@ function loadPEM(n) {
}

const testCases = [
{ // Test 0: for the check of a cert not in the whitelist.
// agent7-cert.pem is issued by the fake CNNIC root CA so that its
// hash is not listed in the whitelist.
// fake-cnnic-root-cert has the same subject name as the original
// rootCA.
serverOpts: {
key: loadPEM('agent7-key'),
cert: loadPEM('agent7-cert')
},
clientOpts: {
port: undefined,
rejectUnauthorized: true,
ca: [loadPEM('fake-cnnic-root-cert')]
},
errorCode: 'CERT_HAS_EXPIRED'
},
// Test 1: for the fix of node#2061
// agent6-cert.pem is signed by intermediate cert of ca3.
// The server has a cert chain of agent6->ca3->ca1(root) but
Expand Down

0 comments on commit 1d72434

Please sign in to comment.