-
Notifications
You must be signed in to change notification settings - Fork 30.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: revert 06cfff9, fixes overridden options
This commit reverts commit 06cfff9 and adds a test that failed before the revert. Options is in fact overridden in the code below the util._extend() call (specifically options.port and options.host) to allow for a one-argument net.createConnection(options) call.
- Loading branch information
1 parent
e61ee49
commit 1c7778d
Showing
2 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const http = require('http'); | ||
|
||
var requests = 0; | ||
|
||
http.createServer(function(req, res) { | ||
res.writeHead(200); | ||
res.end('ok'); | ||
|
||
requests++; | ||
}).listen(common.PORT).unref(); | ||
|
||
var agent = new http.Agent(); | ||
agent.defaultPort = common.PORT; | ||
|
||
// options marked as explicitly undefined for readability | ||
// in this test, they should STAY undefined as options should not | ||
// be mutable / modified | ||
var options = { | ||
host: undefined, | ||
hostname: 'localhost', | ||
port: undefined, | ||
defaultPort: undefined, | ||
path: undefined, | ||
method: undefined, | ||
agent: agent | ||
}; | ||
|
||
http.request(options, function(res) { | ||
res.resume(); | ||
}).end(); | ||
|
||
process.on('exit', function() { | ||
assert.equal(requests, 1); | ||
|
||
assert.strictEqual(options.host, undefined); | ||
assert.strictEqual(options.hostname, 'localhost'); | ||
assert.strictEqual(options.port, undefined); | ||
assert.strictEqual(options.defaultPort, undefined); | ||
assert.strictEqual(options.path, undefined); | ||
assert.strictEqual(options.method, undefined); | ||
}); |