Skip to content

Commit

Permalink
test: change buffer offset to accommodate V8 BackingStore
Browse files Browse the repository at this point in the history
To avoid problem with the behavior of new V8 BackingStore API,
change the offset. The base address of each test case will be
different.

Fixes: #31061

PR-URL: #31171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
thangktran authored and targos committed Jan 14, 2020
1 parent 20a8175 commit 18cd002
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions test/addons/buffer-free-callback/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,24 @@ function check(size, alignment, offset) {
global.gc();
}

// NOTE: If adding more check() test cases,
// be sure to not duplicate alignment/offset.
// Refs: https://github.com/nodejs/node/issues/31061#issuecomment-568612283

check(64, 1, 0);

// Buffers can have weird sizes.
check(97, 1, 0);
check(97, 1, 1);

// Buffers can be unaligned
check(64, 8, 0);
check(64, 16, 0);
check(64, 8, 1);
check(64, 16, 1);
check(97, 8, 1);
check(97, 16, 1);
check(97, 8, 3);
check(97, 16, 3);
check(97, 8, 5);
check(97, 16, 5);

// Empty ArrayBuffer does not allocate data, worth checking
check(0, 1, 0);
check(0, 1, 2);

0 comments on commit 18cd002

Please sign in to comment.