fixup: suggestions

nodejs · Mar 11, 2020 · 1415464 · 1415464
1 parent bed9a32
commit 1415464
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/internal/streams/pipeline.js b/lib/internal/streams/pipeline.js
@@ -43,7 +43,7 @@ function isOutgoing(stream) {
 
 function destroyer(stream, reading, writing, final, callback) {
   const _destroy = once((err) => {
-    if (!err && ((isIncoming(stream) || isOutgoing(stream)))) {
+    if (!err && (isIncoming(stream) || isOutgoing(stream))) {
       // http/1 request objects have a coupling to their response and should
       // not be prematurely destroyed. Assume they will handle their own
       // lifecycle.

diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -1016,7 +1016,7 @@ const { promisify } = require('util');
   const server = http.createServer((req, res) => {
     req.socket.on('error', common.mustNotCall());
     pipeline(req, new PassThrough(), (err) => {
-      assert(!err);
+      assert.ifError(err);
       res.end();
       server.close();
     });