Skip to content

Commit

Permalink
test: remove unneeded bind() and related comments
Browse files Browse the repository at this point in the history
As mentioned in the comment of the changed file, "a libuv limitation
makes it necessary to bind()". But, that is not the case in this test.
The subsequent call to send() results in an implicit bind().

PR-URL: #5023
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
  • Loading branch information
aayn authored and Myles Borins committed Mar 17, 2016
1 parent 659ef2d commit 12eae07
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/internet/test-dgram-multicast-multi-process.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ if (process.argv[2] !== 'child') {
}

var sendSocket = dgram.createSocket('udp4');
// FIXME: a libuv limitation makes it necessary to bind()
// before calling any of the set*() functions. The bind()
// call is what creates the actual socket.
sendSocket.bind();

// The socket is actually created async now.
sendSocket.on('listening', function() {
Expand Down

0 comments on commit 12eae07

Please sign in to comment.