This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
src: fix intermittent SIGSEGV in resolveTxt #9300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records`
|
LGTM |
1 similar comment
|
LGTM |
|
ping |
|
Any update on this PR? |
|
Also would love to see a merge of this fix. |
|
This is incorrect. 0.12 nodejs isn't stable and should not be used in production. |
|
@celesteking ... minor correction: |
|
yeah, especially when you get a SIGSEGV on production box. Right. |
|
BTW, we switched to native-dns as a workaround. |
|
Landed in 261fa36 |
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` Fixes: nodejs#9285 PR-URL: nodejs#9300 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a SIGSEGV by making sure
txt_chunkis not empty before settingit on
txt_recordsRef: #9285
This is the same fix applied in nodejs/node#960