-
Notifications
You must be signed in to change notification settings - Fork 7.3k
fix fs.truncate when first arg is an int fd #9161
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// Copyright Joyent, Inc. and other Node contributors. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a | ||
// copy of this software and associated documentation files (the | ||
// "Software"), to deal in the Software without restriction, including | ||
// without limitation the rights to use, copy, modify, merge, publish, | ||
// distribute, sublicense, and/or sell copies of the Software, and to permit | ||
// persons to whom the Software is furnished to do so, subject to the | ||
// following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included | ||
// in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
// USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var path = require('path'); | ||
var fs = require('fs'); | ||
var tmp = common.tmpDir; | ||
if (!fs.existsSync(tmp)) | ||
fs.mkdirSync(tmp); | ||
var filename = path.resolve(tmp, 'truncate-file.txt'); | ||
|
||
var success = 0; | ||
|
||
fs.writeFileSync(filename, 'hello world', 'utf8'); | ||
var fd = fs.openSync(filename, 'r+'); | ||
fs.truncate(fd, 5, function(err) { | ||
assert.ok(!err); | ||
success++; | ||
}); | ||
|
||
process.on('exit', function() { | ||
fs.closeSync(fd); | ||
fs.unlinkSync(filename); | ||
assert.equal(success, 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I still don't think it's necessary to check for success. However, one thing you can add here is cleanup of the temp file used by the test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The bug is that the callback is replaced by an instance of FSReqWrap. So no callback is called (and no exception is thrown). So I need another way to detect that something went wrong. Verifying the number of assertions at exit time does the job. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test file that I provided 1) reproduces the bug, 2) produces a clear message that there is a bug and 3) passes when the bug is fixed. The alternative that you are proposing misses 2) because the test completes without any message. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, my mistake was assuming that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep. I was actually surprised to not get an exception. |
||
console.log('ok'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this and the
process.on('exit', ...)
can be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exit test is necessary. Otherwise the test exits without any diagnostics on the broken implementation.