This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix joyent/node#8683 #8744
Closed
Fix joyent/node#8683 #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool is_extern_ascii = is_extern && str->IsExternalAscii(); | ||
| if (is_extern) { | ||
| if (is_extern_ascii) { | ||
| str = String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>(data), String::NewStringType::kNormalString, len); |
|
Looks really good! Could you please fix some minor style issues? |
|
@indutny Fixed according to your suggestion. And also fixed building and test case issue on OSX. Please check this commit. |
| @@ -119,12 +119,30 @@ size_t Length(Handle<Object> obj) { | |||
|
|
|||
| Local<Object> New(Isolate* isolate, Handle<String> string, enum encoding enc) { | |||
| EscapableHandleScope scope(isolate); | |||
|
|
|||
| size_t length = StringBytes::Size(isolate, string, enc); | |||
| Local<String> tmp_string; | |||
There was a problem hiding this comment.
If I'm reading #8683 correctly the issue is that the length computation is incorrect. Creating a temporary string doesn't seem necessary at all. Why not just the length computation?
There was a problem hiding this comment.
I don't know how to compute the length correctly for each encoding. But creating a temporary string is the simplest way to fix this issue.
|
@trevnorris ... did you ever have a chance to look at this? |
|
@jasnell this has been fixed in nodejs/node@1640dedb3. I'd just pick that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the encoding issue of converting external string into Buffer (#8683).