This repository was archived by the owner on Apr 22, 2023. It is now read-only.
net: Allow custom DNS resolvers #8564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net.connect now checks whether the user has provided a dns resolution function, this arguments and expected output for which mirror the existing dns.lookup implementation. Fixes nodejs#8475
| var assert = require('assert'); | ||
| var net = require('net'); | ||
|
|
||
| var resolver_called = false; |
There was a problem hiding this comment.
Please prefer camelCase in JavaScript code.
|
Unfortunately this appears to have stalled out. At this point this is something that would likely need to be closed here and reopened with a new PR at http://github.com/nodejs/node. @cjihrig ... any further thoughts? |
|
I think we can close this, based on the resolution of #8475 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.connect now checks whether the user has provided a dns
resolution function, this arguments and expected output
for which mirror the existing dns.lookup implementation.
Fixes #8475