This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
prevent domain.intercept passing 1st arg to cb #3380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes on the commit for possible performance hazard. Otherwise the code lgtm. Can you update docs/api/domain.markdown as well? |
|
@isaacs I did include an update api doc, will that work? also updated the code to be more optimized, i wasn't tracking on using named arg, so if you need me to do something else just let me know based on the code. |
|
Landed on 569acea. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As related to discussion on issue #3379