This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Throw if fs start arg is not number #2780
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
(function () { | ||
"use strict"; | ||
|
||
var assert = require('assert'), | ||
fs = require('./fs'), | ||
saneEmitter; | ||
|
||
saneEmitter = fs.createReadStream(__filename, { start: 17, end: 29 }); | ||
|
||
assert.throws(function () { | ||
fs.createReadStream(__filename, { start: "17", end: 29 }); | ||
}, "start as string didn't throw an error for createReadStream"); | ||
|
||
assert.throws(function () { | ||
fs.createReadStream(__filename, { start: 17, end: "29" }); | ||
}, "end as string didn't throw an error"); | ||
|
||
assert.throws(function () { | ||
fs.createWriteStream(__filename, { start: "17" }); | ||
}, "start as string didn't throw an error for createWriteStream"); | ||
|
||
saneEmitter.on('data', function (data) { | ||
// a sanity check when using numbers instead of strings | ||
assert.strictEqual('"use strict";', data.toString('utf8'), 'read ' + data.toString('utf8') + ' instead of "use strict";'); | ||
}); | ||
}()); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor beans, but I think the "left" should be removed (sounds a little better IMO), as well as "not a string containing a number" (you're not sure that this is the case, what if it's an Object of some sort?)