-
Notifications
You must be signed in to change notification settings - Fork 7.3k
timer: call list.start regardless new or not #25832
Conversation
What a great fix! This should be included asap! |
+1 |
To paraphrase my comment in #25831:
|
This looks good but would you be able to include a test case for it? |
Call start regardless whether list is new or not to prevent incorrect active_handles count. Fixes nodejs#25831.
@jasnell, a test case would require either writing a c++ module or obtaining |
👍 |
cc @Fishrock123 |
If it's impossible to write a test without external dependencies, then it's not a bug |
I think this is a bug. My tired self does not think that the proposed patch could actually fix this. We'll see tomorrow maybe. |
added test case
4f2de45
to
e340cb6
Compare
I have added a test case, without any dependencies. Confirmed test case caused existing version 0.12.7 hung but passed with the fix. |
deleted config.gypi
@abbr could we move this issue to https://github.com/nodejs/node? I'd prefer to review it there. |
@Fishrock123 so what's the bug? running |
@Fishrock123, I have ported this pr to nodejs/node#2788 |
Closing here. |
Call start regardless whether list is new
or not to prevent incorrect active_handles
count.
Fixes issue #25831.