This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
gyp_addon: Include the node.lib file at link time on Windows. #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the basic `gyp_addon` script work with Windows. The "Debug" dir is currently hard-coded. A better way would be to use the currently selected "configuration" that gyp is executing, but I could not figure out how to get a variable of the configuration...
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Sep 18, 2015
Notable changes: * events: Added EventEmitter#listenerCount(event) as a replacement for EventEmitter.listenerCount(emitter, event), which has now been marked as deprecated in the docs. (Sakthipriyan Vairamani) nodejs#2349 * module: Fixed an error with preloaded modules when the current working directory doesn't exist. (Bradley Meck) nodejs#2353 * node: Startup time is now about 5% faster when not passing V8 flags. (Evan Lucas) nodejs#2483 * repl: Tab-completion now works better with arrays. (James M Snell) nodejs#2409 * string_bytes: Fixed an unaligned write in the handling of UCS2 encoding. (Fedor Indutny) nodejs#2480 * tls: Added a new --tls-cipher-list flag that can be used to override the built-in default cipher list. (James M Snell) nodejs#2412
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the basic
gyp_addonscript work with Windows.The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...