This repository was archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Uncatchable client errors #3239
Labels
Comments
CC @mranney |
There's a bug in your test. Try this: diff --git a/test.js b/test.js
index 2cbcd81..9630809 100644
--- a/test.js
+++ b/test.js
@@ -20,7 +20,7 @@ var options = {
};
setInterval(function() {
- http.get(options, onResponse, onError);
+ http.get(options, onResponse).on('error', onError);
function onResponse(res) {
console.log("Response:", res); |
Seems perhaps related to #3236? |
shigeki
pushed a commit
to shigeki/node-v0.x-archive
that referenced
this issue
Oct 16, 2015
Add SIGTRAP and the corresponding exit code to the list of signals/exit codes that are expected when running tests that throw an uncaught error and have --abort-on-uncaught-exception enabled. Also refactor a bit related comments so that they better reflect what's actually happening. Fixes nodejs#3239. PR: nodejs#3354 PR-URL: nodejs/node#3354 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Nov 5, 2015
Add SIGTRAP and the corresponding exit code to the list of signals/exit codes that are expected when running tests that throw an uncaught error and have --abort-on-uncaught-exception enabled. Also refactor a bit related comments so that they better reflect what's actually happening. Fixes nodejs#3239. PR: nodejs#3354 PR-URL: nodejs/node#3354 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@bnoordhuis @isaacs <-- Calling the experts
The text was updated successfully, but these errors were encountered: