This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: VS2015 failure (ICU) back port from io.js #25792
Assignees
Labels
Comments
srl295
added a commit
to srl295/node-v0.x-archive
that referenced
this issue
Jul 31, 2015
probably fixes nodejs#25792 Also, adds general mechanism for floating patches on top of ICU. The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. backport from: nodejs/node#2283
srl295
added a commit
to srl295/node-v0.x-archive
that referenced
this issue
Aug 3, 2015
probably fixes nodejs#25792 Also, adds general mechanism for floating patches on top of ICU. The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. backport from: nodejs/node#2283 * includes responses to comments in from io.js version * also apply patch to ICU 55 (if/when that is merged)
srl295
added a commit
to srl295/node-v0.x-archive
that referenced
this issue
Aug 4, 2015
probably fixes nodejs#25792 Also, adds general mechanism for floating patches on top of ICU. The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. backport from: nodejs/node#2283 * includes responses to comments in from io.js version * also apply patch to ICU 55 (if/when that is merged)
srl295
added a commit
that referenced
this issue
Aug 24, 2015
This change is a backport of nodejs/node@4c06515. Original commit message: The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. Also, adds general mechanism for floating patches on top of ICU. Fixes: nodejs/node#2279 PR-URL: nodejs/node#2283 Reviewed-By: João Reis <reis@janeasystems.com> Fixes: #25792 PR-URL: #25804 Reviewed-By: João Reis <reis@janeasystems.com>
|
Fixed by 4f24563. |
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this issue
Nov 4, 2016
This change is a backport of nodejs/node@4c06515. Original commit message: The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. Also, adds general mechanism for floating patches on top of ICU. Fixes: nodejs/node#2279 PR-URL: nodejs/node#2283 Reviewed-By: João Reis <reis@janeasystems.com> Fixes: nodejs#25792 PR-URL: nodejs#25804 Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
nodejs/node#2279 will affect 0.12+ as well under VS2015 with
Intlon.Basically, VS2015 broke ICU. We'll fix it in ICU 56.
It should apply cleanly, but I couldn't get VS2015 to build with
joyent/node/master.I will open a PR anyway, but will need some help testing.
NB this also adds a general mechanism for floating patches on top of ICU.
@orangemocha
The text was updated successfully, but these errors were encountered: