net: defer DNS lookup error events to next tick

net.createConnection() creates a net.Socket object and immediately calls net.Socket.connect() on it. There are no event listeners registered yet so defer the error event to the next tick. Fixes #1202.
nodejs · Aug 9, 2011 · 60fd7e6 · 60fd7e6
1 parent c318bd6
commit 60fd7e6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/net_legacy.js b/lib/net_legacy.js
@@ -728,7 +728,13 @@ Socket.prototype.connect = function() {
     // TCP
     require('dns').lookup(host, function(err, ip, addressType) {
       if (err) {
-        self.emit('error', err);
+        // net.createConnection() creates a net.Socket object and
+        // immediately calls net.Socket.connect() on it (that's us).
+        // There are no event listeners registered yet so defer the
+        // error event to the next tick.
+        process.nextTick(function() {
+          self.emit('error', err);
+        });
       } else {
         timers.active(self);
         self.type = addressType == 4 ? 'tcp4' : 'tcp6';

diff --git a/lib/net_uv.js b/lib/net_uv.js
@@ -449,7 +449,13 @@ Socket.prototype.connect = function(port /* [host], [cb] */) {
     debug("connect: find host " + host);
     require('dns').lookup(host, function(err, ip, addressType) {
       if (err) {
-        self.emit('error', err);
+        // net.createConnection() creates a net.Socket object and
+        // immediately calls net.Socket.connect() on it (that's us).
+        // There are no event listeners registered yet so defer the
+        // error event to the next tick.
+        process.nextTick(function() {
+          self.emit('error', err);
+        });
       } else {
         timers.active(self);