Update to node20 #17
Open
Update to node20 #17
+38,085
−9,693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also update the test workflow to confirm the code works on Node.js 20? |
|
Sure! I'm currently resolving failures with the update |
avivkeller
force-pushed
the
patch-1
branch
2 times, most recently
from
ce0a062 to
f7e1bac
Compare
|
Okay. All is ready. All the dependencies have also been updated, as the original versions did not support Node.js v20. |
targos
reviewed
Oct 2, 2024
avivkeller
force-pushed
the
patch-1
branch
2 times, most recently
from
71c5d32 to
b2f81c6
Compare
|
The |
|
@targos do you want me to refactor the code to make use of features introduced between v12 and v20, if any, or should that be done in separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Closes #15
Closes #14
Closes #13