Quick and dirty fix to allow WriteXmlIfChanged to write xml in utf-8, co... #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty fix to allow node-gyp to generate the vcxproj when the are latin-1 characters in the paths.
I'm not a python programmer, this just solved the problem I had with latin-1 characters..
WriteXmlIfChanged was not actually writing in utf-8, but in ascii. Converting directly to utf-8 would fail if unicode(string, native_enconding) is not called first.