Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid bare exceptions in xcode_emulation.py #1932

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 21, 2019

https://realpython.com/the-most-diabolical-python-antipattern/

Related to #1927

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@cclauss
Copy link
Contributor Author

cclauss commented Oct 22, 2019

@rvagg This includes a change to the Travis macOS test to gracefully deal with the situation where Node is already installed.

@cclauss cclauss requested review from rvagg and sam-github October 22, 2019 10:45
rvagg pushed a commit that referenced this pull request Oct 22, 2019
rvagg pushed a commit that referenced this pull request Oct 22, 2019
PR-URL: #1932
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Oct 22, 2019

landed

@rvagg rvagg closed this Oct 22, 2019
@rvagg rvagg deleted the avoid-bare-exceptions-in-xcode_emulation.py branch October 22, 2019 10:49
@cclauss cclauss added the Python label Nov 7, 2019
rvagg pushed a commit that referenced this pull request Nov 18, 2019
rvagg pushed a commit that referenced this pull request Nov 18, 2019
PR-URL: #1932
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants