-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add to .gitignore #1573
Closed
Closed
meta: add to .gitignore #1573
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
5f924ce
Upgrade to tar v3
isaacs 75cfae2
bump to v4.0.0
refack c84a541
configure: don't set ensure if tarball is set
gibfahn d6139b5
gyp: update xml string encoding conversion
lc-soft 35e1dbb
doc: headerify the Install instructions
nschonni 2e40fad
doc: update proposed DCO and CoC
mikeal 7245415
doc: add github PR and Issue templates
gibfahn 63f43c2
win: run PS with `-NoProfile`
refack a8ba528
zos: support platform
jBarz 05d2002
Fix IndexError when parsing GYP files.
bnoordhuis 6b68b60
Update README with another way to install on windows
JeffAtDeere 57279a2
Update `--nodedir` description in README.
bnoordhuis 8b7ccfe
Fix infinite install loop.
bnoordhuis 3a52936
gyp: don't print xcodebuild not found errors
gibfahn 91789c2
doc: update macOS information in README
josh- 293092c
gyp: fix regex to match multi-digit versions
jhermsmeier 02ac2e7
zos: add search locations for libnode.x
jBarz eaedc12
zos: don't use universal-new-lines mode
jBarz 206309e
gyp: add support for .mm files to msvs generator
jracle 4379c47
Prefix build targets with /t: on Windows
NatalieWolfe fbecb38
Fix include path when pointing to Node.js source
richardlau d70513a
Drop dependency on minimatch.
doowb 1cf636b
gyp: escape spaces in filenames in make generator
50b8734
Remove unused gyp test scripts.
bnoordhuis c5e9802
doc: lint README.md
maclover7 6b0f4ae
bin,lib: remove extra comments/lines/spaces
maclover7 b2e5cf0
Add ESLint no-unused-vars rule
maclover7 25208f1
win: improve parsing of SDK version
Loghorn da5db40
configure: use sys.version_info to get python version
hashseed 1309efb
doc: fix visual studio links
bzoz a0cf9d5
doc: update link to commit guidelines
jhermsmeier d9ee0ea
doc: update Xcode preferences tab name.
divan fb2d3a2
deps: pin `request` version range
refack baa0616
deps: bump request to 2.8.7, fixes heok/hawk issues
Rohithzr eb78b5a
test: added test/processExecSync.js for when execFileSync is not avai…
Rohithzr 877b83b
test: formatting and minor fixes for execFileSync replacement
rvagg 8ad9ecd
gyp: backport GYP fix to fix AIX shared suffix
a265040
gyp: float gyp patch for long filenames
addaleax 5c2aad8
gyp: add compile_commands.json gyp generator
bnoordhuis 6ffef51
gyp: enable cctest to use objects (gyp part)
danbev f739c18
gyp: implement LD/LDXX for ninja and FIPS
sam-github d8eac7a
tools: fix "the the" typos in comments
eebc8f6
tools: patch gyp to avoid xcrun errors
ryzokuken 2ca32e0
gyp: fix ninja build failure (GYP patch)
danbev bac9e44
doc: update changelog
rvagg 3481739
test: remove unused variable
joaocgreis c9276f3
gyp: get ready for python 3
73b5b63
gyp: use print as a function, as specified in PEP 3105.
rodrigc 3321444
gyp: replace deprecated functions
rodrigc 9eb9b39
gyp: replace basestring with str, but only on Python 3.
rodrigc ef8b60a
gyp: _winreg module was renamed to winreg in Python 3.
rodrigc ae0be87
gyp: fix sntex error
2394a1e
gyp: fix target --> self.target
020e2bd
meta: add to .gitignore
refack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| env: | ||
| node: true | ||
| rules: | ||
| no-unused-vars: error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <!-- | ||
| Thank you for reporting an issue. The more information you can give us, the | ||
| better the chance we can fix your problem. | ||
|
|
||
| This issue tracker is for issues with node-gyp, | ||
| if you have an issue installing a specific module, please file an issue on | ||
| that module's issue tracker (`npm issues modulename`). | ||
| --> | ||
|
|
||
| * **Node Version**: <!-- `node -v` and `npm -v` --> | ||
| * **Platform**: <!-- `uname -a` (UNIX), or `systeminfo | findstr /B /C:"OS Name" /C:"OS Version" /C:"System Type"` (Windows) --> | ||
| * **Compiler**: <!-- `cc -v` (UNIX) or `msbuild /version & cl` (Windows) --> | ||
| * **Module**: <!-- what you tried to build/install --> | ||
|
|
||
| <details><summary>Verbose output (from npm or node-gyp):</summary> | ||
|
|
||
| <!-- Paste your log between the backticks. Contents of npm-debug.log or verbose build output --> | ||
|
|
||
| ``` | ||
|
|
||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| <!-- Any further details --> | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!-- | ||
| Thank you for your pull request. Please review the below requirements. | ||
|
|
||
| Contributor guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md | ||
| --> | ||
|
|
||
| ##### Checklist | ||
| <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> | ||
|
|
||
| - [ ] `npm install && npm test` passes | ||
| - [ ] tests are included <!-- Bug fixes and new features should include tests --> | ||
| - [ ] documentation is changed or added | ||
| - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines) | ||
|
|
||
| ##### Description of change | ||
| <!-- Provide a description of the change --> | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| gyp/test | ||
| node_modules | ||
| test/.node-gyp | ||
| .ncu | ||
| package-lock.json | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Contributing to node-gyp | ||
|
|
||
| ## Code of Conduct | ||
|
|
||
| Please read the | ||
| [Code of Conduct](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md) | ||
| which explains the minimum behavior expectations for node-gyp contributors. | ||
|
|
||
| <a id="developers-certificate-of-origin"></a> | ||
| ## Developer's Certificate of Origin 1.1 | ||
|
|
||
| By making a contribution to this project, I certify that: | ||
|
|
||
| * (a) The contribution was created in whole or in part by me and I | ||
| have the right to submit it under the open source license | ||
| indicated in the file; or | ||
|
|
||
| * (b) The contribution is based upon previous work that, to the best | ||
| of my knowledge, is covered under an appropriate open source | ||
| license and I have the right under that license to submit that | ||
| work with modifications, whether created in whole or in part | ||
| by me, under the same open source license (unless I am | ||
| permitted to submit under a different license), as indicated | ||
| in the file; or | ||
|
|
||
| * (c) The contribution was provided directly to me by some other | ||
| person who certified (a), (b) or (c) and I have not modified | ||
| it. | ||
|
|
||
| * (d) I understand and agree that this project and the contribution | ||
| are public and that a record of the contribution (including all | ||
| personal information I submit with it, including my sign-off) is | ||
| maintained indefinitely and may be redistributed consistent with | ||
| this project or the open source license(s) involved. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually commit the package-lock.json
see: https://stackoverflow.com/a/44210813
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I too wonder why is this ignored... cc @refack ...