Python info needs own header #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Jun 30, 2017
README.md
Outdated
| @@ -66,6 +66,8 @@ Install tools and configuration manually: | |||
|
|
|||
| If the above steps didn't work for you, please visit [Microsoft's Node.js Guidelines for Windows](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules) for additional tips. | |||
|
|
|||
| ## Configuring Python Dependency | |||
|
|
|||
| If you have multiple Python versions installed, you can identify which Python | |||
| version `node-gyp` uses by setting the '--python' variable: | |||
There was a problem hiding this comment.
Since we're editing, the quotes around --python could be fixed.
gibfahn
reviewed
Jun 30, 2017
README.md
Outdated
| If you have multiple Python versions installed, you can identify which Python | ||
| version `node-gyp` uses by setting the '--python' variable: | ||
| version `node-gyp` uses by setting the "--python" variable: |
There was a problem hiding this comment.
I'm 99% sure @richardlau meant `--python`
gibfahn
approved these changes
Jun 30, 2017
richardlau
approved these changes
Jun 30, 2017
refack
approved these changes
Jun 30, 2017
|
Anyone knows if there is a POSIX equivalent to PEP514? |
|
Ahhh H-E-double-hockey-sticks, I'm gonna do the |
|
@refack Which holiday? |
Exactly 😞 |
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
PR-URL: #1245 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There must be some kind of separation there in the Readme. It isn't clear this isn't part of the Windows installation information.