-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tape with tap #1171
Replace tape with tap #1171
Conversation
Thanks, this is great! I wonder though, does |
Correct, |
Yes. |
Is it possible to move the tests which need isolation into individual files? Which tests need this? I can look into doing that step as part of this ticket. |
I'm going to say 'all of them' - it's not really true but isolation never hurts. It's my original plan of attack for #1123. |
Is that necessary up front? That seems like the kind of thing that could be resolved on a case-by-case basis when colliding tests are discovered. Moving individual tests into separate files isn't that hard, but seems like overkill if you don't actually need them isolated. |
Such things tend to go unnoticed, though. I raised #1123 after I found two unrelated tests had been clobbering each other undetected for some time. Another anecdote: a project I was involved in had a bug caused by lack of isolation that stopped half the tests from running but it went undiscovered for a year because the CI was green all the time. |
}, | ||
"scripts": { | ||
"test": "tape test/test-*" | ||
"test": "tap test/test-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO need to add -Rtap
@NatalieWolfe do you need help? I can help... |
ping @NatalieWolfe |
needs to be updated, either @NatalieWolfe needs to revisit or someone else should open a PR, I'd +1 on merging this if it was ready |
@NatalieWolfe Is this already done elsewhere or is there more to do here? |
This was done in #1795. |
The tap module is a more fully featured TAP framework that executes its tests in separate child processes.
Resolves #1123