-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
win: work around __pfnDliNotifyHook2 type change
Visual Studio 2015 Update 3 defines __pfnDliNotifyHook2 as const. The decltype specifier makes the declaration work across all supported versions of VS. It also requires that the source be compiled as C++. Fixes: #949 PR-URL: #952 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
- Loading branch information
1 parent
3df8222
commit f31482e
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orangemocha How did you merge this?
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@orangemocha committed on GitHub 3 hours ago"
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR branch with the commit metadata, then I used Github's new merge-squash functionality. Is that not ok? I have to admit it's the first time I tried doing it this way.
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orangemocha It should be, maybe it just didn't used to display like that when I did it. Seems slightly confusing, but I don't have an issue with it. (So long as it doesn't make more sense as multiple commits)
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to remove the PR #, which gets suggested as an append to the original commit message. Other than that, the results look exactly the same in git history. I think it will squash multiple commits, so it's a valid alternative only for single-commit PRs.
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fishrock123 ^
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the interruption.i would like to ask that in order to make libxmljs compile(it can't compile node-gyp due to the specific error) what should i do? thanks!
ps:forget it i found where i should put the files :)
f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tasoss if you want a hack until this fix is released with Node, you could try to apply it to your Node installation, under
node_modules\npm\node_modules\node-gyp
.f31482e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that what's i have done because i had to continue my work.Thanks!!