Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Override BUILDING_UV_SHARED, BUILDING_V8_SHARED.
We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from the common.gypi from the node.js source tree. Override them with USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with `__declspec(dllimport)` instead of `__declspec(dllexport)`, which is the desired attribute when building add-ons. Fixes: #914 PR-URL: #915 Reviewed-By: Benjamin Byholm <bbyholm@abo.fi> Reviewed-By: Fedor Indutny <fedor@indutny.com>
- Loading branch information