This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
src,test: enable per_context.js shim
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if tests pass; what changed to make the intl initialization not fatal? Does intl actually work if ICU isn't configured the first time we touch the intl object? |
|
glad to see this 🎉 just so you know, we're updating the Atomics shim upstream to flip it sorta like you did here, so there might be a merge conflict there at some point. |
|
It will be a little while before this hits a nightly, but at least we should have everything ready when we are able to move to a newer version of ChakraCore. |
|
@devsnek I grabbed the current state of nodejs/node#22844 and applied that instead of my divergent change. PTAL if you have time. |
MSLaguana
approved these changes
Sep 18, 2018
devsnek
approved these changes
Sep 18, 2018
|
Since the change just landed upstream, I'll just hold off for now and rebase on top of it. Thanks for taking a look! |
jackhorton
approved these changes
Sep 18, 2018
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Sep 18, 2018
This reverts commit f5d29d5. PR-URL: nodejs#600 Refs: nodejs#565 Refs: nodejs#567 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
This reverts commit f5d29d5. PR-URL: nodejs#600 Refs: nodejs#565 Refs: nodejs#567 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires a new version of ChakraCore, making the change in
chakracore-masterbranch for now to get some testingThis reverts commit f5d29d5. It also
updates the shim to use shim
wakeusingnotify.Refs: #565
Refs: #567
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes