This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
doc: fix broken markdown link #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kunalspathak It seems like we could simplify the build instructions a bit? Build Command: vcbuild [x86|x64|arm]To run unit tests vcbuild nobuild test ignore-flaky [x86|x64|arm]EDIT: I've updated the build/test instructions to reflect the current state of the repo. |
kunalspathak
approved these changes
Jun 28, 2017
|
@kunalspathak and I chatted and he opened #320 to track advanced build scenarios. |
* Fixed malformed link * Added link to Homebrew * Updated the build instructions PR-URL: nodejs#319 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jul 7, 2017
* Fixed malformed link * Added link to Homebrew * Updated the build instructions PR-URL: nodejs#319 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc