Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: skip failing tests for ChakraCore
Browse files Browse the repository at this point in the history
* Skip part of `test-util-inspect` since it exhausts the stack
* Skip `test-vm-createcacheddata` since the shim isn't implemented
  • Loading branch information
Mike Kaufman authored and kfarnung committed Jul 10, 2018
1 parent 43583d9 commit 3b49f28
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,10 @@ test-worker-uncaught-exception-async : SKIP
test-worker-unsupported-things : SKIP
test-worker-workerdata-sharedarraybuffer : SKIP

# Chakra doesn't yet support createCachedData.
# See bug https://github.com/nodejs/node-chakracore/issues/560
test-vm-createcacheddata : SKIP

[$jsEngine==chakracore && $arch==x64]
# These tests are failing for Node-Chakracore and should eventually be fixed
test-buffer-includes : SKIP
Expand Down
4 changes: 3 additions & 1 deletion test/parallel/test-util-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -1473,12 +1473,14 @@ if (!common.isChakraEngine) {
assert.strictEqual(util.inspect(args), "[Arguments] { '0': 'a' }");
}

{
// Chakra exhausts stack w/ fairly low value, so just skipping this test
if (!common.isChakraEngine) {
// Test that a long linked list can be inspected without throwing an error.
const list = {};
let head = list;
// A linked list of length 100k should be inspectable in some way, even though
// the real cutoff value is much lower than 100k.

for (let i = 0; i < 100000; i++)
head = head.next = {};
assert.strictEqual(
Expand Down

0 comments on commit 3b49f28

Please sign in to comment.