Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unnecessary symbol exposure #896

Closed
wants to merge 2 commits into from

Conversation

gabrielschulhof
Copy link
Contributor

The symbol generated by NODE_API_MODULE() is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it static fixes a
warning.

Fixes: #888

Gabriel Schulhof added 2 commits February 1, 2021 08:38
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it `static` fixes a
warning.

Fixes: nodejs#888
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gabrielschulhof pushed a commit that referenced this pull request Feb 8, 2021
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it `static` fixes a
warning.

Fixes: #888
PR-URL: #896
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

Landed in 4d856f6.

@gabrielschulhof gabrielschulhof deleted the static-init branch February 8, 2021 19:21
@addaleax
Copy link
Member

@gabrielschulhof @NickNaso Do you think this could be released? I just ran into this bug and it’s awesome that it’s solved already, but it’s also been half a year since the last release :)

addaleax added a commit to mongodb-js/os-dns-native that referenced this pull request May 11, 2021
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it `static` fixes a
warning.

Fixes: nodejs/node-addon-api#888
PR-URL: nodejs/node-addon-api#896
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it `static` fixes a
warning.

Fixes: nodejs/node-addon-api#888
PR-URL: nodejs/node-addon-api#896
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it `static` fixes a
warning.

Fixes: nodejs/node-addon-api#888
PR-URL: nodejs/node-addon-api#896
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily.
It is sufficient for it to be a local symbol because it is passed
around as a function pointer. Furthermore, making it `static` fixes a
warning.

Fixes: nodejs/node-addon-api#888
PR-URL: nodejs/node-addon-api#896
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on NODE_API_MODULE macro
3 participants