Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: some typos in documentation #826

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix: some typos in documentation #826

merged 1 commit into from
Oct 26, 2020

Conversation

helio-frota
Copy link
Contributor

No description provided.

NickNaso
NickNaso reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Thanks for the contribution.

doc/addon.md Outdated Show resolved Hide resolved
NickNaso
NickNaso approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NickNaso NickNaso mentioned this pull request Oct 26, 2020
Closed
9 tasks
@jschlight jschlight self-requested a review October 26, 2020 16:17
jschlight
jschlight approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jschlight jschlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 35b6571 into nodejs:master Oct 26, 2020
@helio-frota helio-frota deleted the fix-typos branch October 26, 2020 19:16
Superlokkus pushed a commit to Superlokkus/node-addon-api that referenced this pull request Nov 20, 2020
@helio-frota @Superlokkus
Fix: some typos in documentation (nodejs#826)
7ac658b
@snyk-bot snyk-bot mentioned this pull request Jan 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickNaso NickNaso NickNaso approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@jschlight jschlight jschlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@helio-frota @NickNaso @tniessen @mhdawson @jschlight