Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add incremental clang-format checks #819

Closed
wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Oct 7, 2020

git-clang-format only check lines modified between two refs.

Fixes: #543

@legendecas legendecas force-pushed the clang-format branch 3 times, most recently from d4e7093 to cb0764a Compare October 8, 2020 05:07
@mhdawson
Copy link
Member

mhdawson commented Oct 8, 2020

Lets talk about this in the next Meeting

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson marked this pull request as draft October 23, 2020 15:16
@legendecas
Copy link
Member Author

Need to separate the linting step from build steps so that we can see the linting result separated from build/test results.

@legendecas legendecas marked this pull request as ready for review November 1, 2020 02:40
@legendecas legendecas force-pushed the clang-format branch 3 times, most recently from b2b26b1 to 427fc4a Compare November 1, 2020 02:54
@legendecas
Copy link
Member Author

It seems like actions were not enabled for those not merged GitHub workflow action files. Please checkout https://github.com/legendecas/node-addon-api/runs/1337409208?check_suite_focus=true for reference.

gabrielschulhof pushed a commit that referenced this pull request Nov 17, 2020
PR-URL: #819
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@gabrielschulhof
Copy link
Contributor

Landed in 8fb5820.

@legendecas legendecas deleted the clang-format branch November 17, 2020 13:38
Superlokkus pushed a commit to Superlokkus/node-addon-api that referenced this pull request Nov 20, 2020
PR-URL: nodejs#819
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
PR-URL: nodejs/node-addon-api#819
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
PR-URL: nodejs/node-addon-api#819
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
PR-URL: nodejs/node-addon-api#819
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#819
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style: add clang-format
3 participants