Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fixed links to array documentation #613

Merged
merged 2 commits into from
Dec 5, 2019
Merged

[doc] Fixed links to array documentation #613

merged 2 commits into from
Dec 5, 2019

Conversation

NickNaso
Copy link
Member

Fixed all the links to Napi::Array documentation.
Fixes issue #612

@zander
Copy link

zander commented Nov 30, 2019

While you are in this file anyway.
The line you changed says "and extends". Which IMOHO is a bit confusing.

Maybe you can change that to say "is extended by".

Napi::Value which is extended by Napi::Array

@zander
Copy link

zander commented Nov 30, 2019

The dead link (to array.md) may be present in other docs pages as well.

I noticed it also in https://github.com/nodejs/node-addon-api/blob/master/doc/value.md

@NickNaso NickNaso added the doc label Nov 30, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit e71d0ea into nodejs:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants