src: guard CallbackScope with N-API v3 #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CallbackScope support needs to be guarded with N-API version 3, otherwise olders versions of N-API that did not have CallbackScope support will have compile failures.
addaleax
approved these changes
Nov 12, 2018
|
@mhdawson I tested and worked good for me. |
|
@nodejs/addon-api @nodejs/abi-stable-node any objections to fast tracking this ? @NickNaso would you be able to do a release in a day or two after this lands? |
|
@mhdawson Yes I can do a release after this fix will be landed. And I provide to open issue right now. |
|
Going to land this as there have been no objections and I think people believe its important to get a fix out relatively quickly. |
mhdawson
added a commit
that referenced
this pull request
Nov 13, 2018
CallbackScope support needs to be guarded with N-API version 3, otherwise olders versions of N-API that did not have CallbackScope support will have compile failures. PR-URL: #395 Fixes: #387 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
|
landed as d47399f |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
CallbackScope support needs to be guarded with N-API version 3, otherwise olders versions of N-API that did not have CallbackScope support will have compile failures. PR-URL: nodejs/node-addon-api#395 Fixes: nodejs/node-addon-api#387 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
CallbackScope support needs to be guarded with N-API version 3, otherwise olders versions of N-API that did not have CallbackScope support will have compile failures. PR-URL: nodejs/node-addon-api#395 Fixes: nodejs/node-addon-api#387 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
CallbackScope support needs to be guarded with N-API version 3, otherwise olders versions of N-API that did not have CallbackScope support will have compile failures. PR-URL: nodejs/node-addon-api#395 Fixes: nodejs/node-addon-api#387 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
CallbackScope support needs to be guarded with N-API version 3, otherwise olders versions of N-API that did not have CallbackScope support will have compile failures. PR-URL: nodejs/node-addon-api#395 Fixes: nodejs/node-addon-api#387 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallbackScope support needs to be guarded
with N-API version 3, otherwise older versions
of N-API that did not have CallbackScope
support will have compile failures.
Fixes: #387