Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add arraybuffer tests #369

Closed
wants to merge 1 commit into from

Conversation

nadongguri
Copy link
Contributor

Hi node-addon-api members,

I added tests for arraybuffer as follows:

  • ArrayBuffer()
  • ArrayBuffer(napi_env env, napi_value value)

I referred to the issue #332.

- ArrayBuffer()
- ArrayBuffer(napi_env env, napi_value value)
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the addition.

mhdawson pushed a commit that referenced this pull request Oct 22, 2018
- ArrayBuffer()
- ArrayBuffer(napi_env env, napi_value value)

PR-URL: #369
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

Landed as 729f6dc

@mhdawson mhdawson closed this Oct 22, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
- ArrayBuffer()
- ArrayBuffer(napi_env env, napi_value value)

PR-URL: nodejs/node-addon-api#369
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
- ArrayBuffer()
- ArrayBuffer(napi_env env, napi_value value)

PR-URL: nodejs/node-addon-api#369
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
- ArrayBuffer()
- ArrayBuffer(napi_env env, napi_value value)

PR-URL: nodejs/node-addon-api#369
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
- ArrayBuffer()
- ArrayBuffer(napi_env env, napi_value value)

PR-URL: nodejs/node-addon-api#369
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants