Code

Fix TODOs to address memory leaks#343

Code

Closed

gabrielschulhof wants to merge 7 commits intonodejs:masternodejs/node-addon-api:masterfrom gabrielschulhof:fix-leak-symbolgabrielschulhof/node-addon-api:fix-leak-symbolCopy head branch name to clipboard

+895-125

Commits

Commits on Sep 28, 2018

• Remove TODOs by fixing memory leaks

  Show description for fe15c7f
  

  Gabriel Schulhof

  committed
  fe15c7f

  Copy full SHA for fe15c7f

• Include tests covering deprecated APIs by default

  Show description for 8166ed1
  

  Gabriel Schulhof

  committed
  8166ed1

  Copy full SHA for 8166ed1

• Add Napi::Object parameter for completeness

  

  Gabriel Schulhof

  committed
  9cbbf8f

  Copy full SHA for 9cbbf8f

• Add comment to remind about using napi_add_finalizer()

  

  Gabriel Schulhof

  committed
  5d164f5

  Copy full SHA for 5d164f5

• copy property descriptors in DefineClass

  

  Gabriel Schulhof

  committed
  0d8609a

  Copy full SHA for 0d8609a

• Update comment regarding preprocessor flag

  

  Gabriel Schulhof

  committed
  b2a76ab

  Copy full SHA for b2a76ab

Commits on Oct 1, 2018

• split deprecated object tests into their own toplevel test

  

  Gabriel Schulhof

  committed
  dcb33cd

  Copy full SHA for dcb33cd