fixup! fixup! src: call napi_remove_wrap() in ObjectWrap dtor

nodejs · Jan 14, 2020 · c243f71 · c243f71
1 parent d668812
commit c243f71
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/napi-inl.h b/napi-inl.h
@@ -3147,8 +3147,12 @@ inline ObjectWrap<T>::ObjectWrap(const Napi::CallbackInfo& callbackInfo) {
 
 template <typename T>
 inline ObjectWrap<T>::~ObjectWrap() {
+  // If the JS object still exists at this point, remove the finalizer added
+  // through `napi_wrap()`.
   if (!IsEmpty()) {
     Object object = Value();
+    // It is not valid to call `napi_remove_wrap()` with an empty `object`.
+    // This happens e.g. during garbage collection.
     if (!object.IsEmpty())
       napi_remove_wrap(Env(), object, nullptr);
   }