Skip to content

Commit

Permalink
travis: remove chakracore on travis
Browse files Browse the repository at this point in the history
1. node-chakracore v8 doesn’t expose napi version
2. node-chakracore v10 doesn’t throws on handlescope double escape
  • Loading branch information
legendecas committed Sep 4, 2019
1 parent 9163f1d commit 464a40b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
9 changes: 0 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,11 @@ env:
# https://github.com/jasongin/nvs/blob/master/doc/CI.md
- NVS_VERSION=1.4.2
matrix:
- NODEJS_VERSION=node/4
- NODEJS_VERSION=node/6
- NODEJS_VERSION=node/8
- NODEJS_VERSION=node/9
- NODEJS_VERSION=node/10
- NODEJS_VERSION=chakracore/8
- NODEJS_VERSION=chakracore/10
- NODEJS_VERSION=nightly
- NODEJS_VERSION=chakracore-nightly
matrix:
fast_finish: true
allow_failures:
- env: NODEJS_VERSION=nightly
- env: NODEJS_VERSION=chakracore-nightly
sudo: false
cache:
directories:
Expand Down
1 change: 1 addition & 0 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ let testModules = [
];

const napiVersion = process.env.npm_config_NAPI_VERSION || process.versions.napi
console.log(`NAPI version defined as ${napiVersion}\n`);

if (napiVersion < 50000) {
// currently experimental only test if NAPI_VERSION
Expand Down

0 comments on commit 464a40b

Please sign in to comment.