-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property Accessors and Context #8
Conversation
re Context, the best way to do this might be best approached by looking at existing uses in Node addons. Who is using this at the moment? Contextify perhaps? Depending on how people want to use it might tell us how best to implement it. Also, Deleters, Enumerators and Queries, are people using these at the moment? Could you point me to uses of them? tbh they're new to me! Otherwise I'm happy with pulling out the args, makes sense to be consistent. |
Yes, all of this is for Contextify, which is a dependency to Paper via jsdom or something. |
yeah, it's a dependency to way too many things, that stuff needs to finally get in to core. if you think it's worth it then just document it up and we may as well complete the API |
Ok, will do. |
document this and we'll get an 0.2.0 out |
Done. |
NanNewContext is a bit currently, this is because Context::New returns a Persistent handle before 0.11, after which it now returns a Local handle. Is there a good way of not having to dispose the persistent context of the old way?