Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property Accessors and Context #8

Merged
merged 12 commits into from
Jul 27, 2013
Merged

Property Accessors and Context #8

merged 12 commits into from
Jul 27, 2013

Conversation

kkoopa
Copy link
Collaborator

@kkoopa kkoopa commented Jul 26, 2013

NanNewContext is a bit currently, this is because Context::New returns a Persistent handle before 0.11, after which it now returns a Local handle. Is there a good way of not having to dispose the persistent context of the old way?

@rvagg
Copy link
Member

rvagg commented Jul 26, 2013

re Context, the best way to do this might be best approached by looking at existing uses in Node addons. Who is using this at the moment? Contextify perhaps? Depending on how people want to use it might tell us how best to implement it.

Also, Deleters, Enumerators and Queries, are people using these at the moment? Could you point me to uses of them? tbh they're new to me!

Otherwise I'm happy with pulling out the args, makes sense to be consistent.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jul 26, 2013

@rvagg
Copy link
Member

rvagg commented Jul 26, 2013

yeah, it's a dependency to way too many things, that stuff needs to finally get in to core.

if you think it's worth it then just document it up and we may as well complete the API

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jul 26, 2013

Ok, will do.

@rvagg
Copy link
Member

rvagg commented Jul 27, 2013

document this and we'll get an 0.2.0 out

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jul 27, 2013

Done.

@kkoopa kkoopa merged commit e53ed24 into 0.2.0 Jul 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants