Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Function::Call wrapper #496

Closed
wants to merge 1 commit into from
Closed

Add Function::Call wrapper #496

wants to merge 1 commit into from

Conversation

kkoopa
Copy link
Collaborator

@kkoopa kkoopa commented Oct 15, 2015

No description provided.

@kkoopa kkoopa added this to the 2.2 milestone Oct 15, 2015
@kkoopa kkoopa mentioned this pull request Oct 15, 2015
Closed
@joshperry
Copy link

I'm using this code in a project and somewhere between v0.10 and v0.12 the recv parameter was changed from Object to Value. I'm going to change the parameter type in the pre_46 ifdef in my code, but I'm not familiar enough with the progression of v8/node to know if that's enough.

Do you know if this ifdef needs to be modified slightly to build properly on v0.12?

@kkoopa
Copy link
Collaborator Author

kkoopa commented Oct 16, 2015

No, Object is a descendant of Value. I've updated the branch.

@kkoopa kkoopa mentioned this pull request Oct 21, 2015
Closed
@kkoopa kkoopa force-pushed the functioncall branch 4 times, most recently from 41fd9ae to 798f1e3 Compare October 22, 2015 20:57
@kkoopa kkoopa mentioned this pull request Nov 17, 2015
Closed
@kkoopa kkoopa closed this Jan 9, 2016
@kkoopa kkoopa deleted the functioncall branch January 9, 2016 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kkoopa @joshperry