Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String encodings #13

Merged
merged 2 commits into from
Aug 4, 2013
Merged

String encodings #13

merged 2 commits into from
Aug 4, 2013

Conversation

kkoopa
Copy link
Collaborator

@kkoopa kkoopa commented Jul 28, 2013

This is for #3.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jul 28, 2013

It would be nice to have a proper test suite. Please test and fix.

@rvagg
Copy link
Member

rvagg commented Jul 29, 2013

yeah, I've been thinking how to do a test suite on all this, it's all getting way more complicated than I imagined.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jul 29, 2013

@trevnorris Could you have a look at this? I am not sure on when zero terminators need to be added, e.g. should buffers get an extra terminating zero? Also, what about the external buffer, will that work as is, or do I need to get at it through ->data()?


size_t sz_;

//Is it external?

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@trevnorris
Copy link
Collaborator

@kkoopa added a few comments.

rvagg added a commit that referenced this pull request Aug 4, 2013
@rvagg rvagg merged commit 233c14c into 0.2.0 Aug 4, 2013
@rvagg rvagg deleted the string_encodings branch August 4, 2013 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants