Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: 1.9 #365

Closed
kkoopa opened this issue May 28, 2015 · 8 comments
Closed

Release proposal: 1.9 #365

kkoopa opened this issue May 28, 2015 · 8 comments
Milestone

Comments

@kkoopa
Copy link
Collaborator

kkoopa commented May 28, 2015

Let's get this out before io.js 3.0 is out, so the 1-series can be laid to rest. There will be no more features added to NAN 1 ever.

Only sort of open issue is #362, but I believe it might be erroneous somehow since all our tests pass and the code is rather straightforward. If it is real it can be fixed in a patch release.

@rvagg
Copy link
Member

rvagg commented May 28, 2015

👍 what's the delta between 1.8.4 and this?

@kkoopa
Copy link
Collaborator Author

kkoopa commented May 28, 2015

Insignificant, IIRC. A couple deprecations, some small additions. The deprecations could even be undone. So much will change that a migratory path through deprecations won't work. There would be hardly any non-deprecated functionality left.

Basically just to tie up a few loose ends and say goodbye to NAN 1.

On May 28, 2015 1:02:29 PM EEST, Rod Vagg notifications@github.com wrote:

👍 what's the delta between 1.8.4 and this?


Reply to this email directly or view it on GitHub:
#365 (comment)

@kkoopa
Copy link
Collaborator Author

kkoopa commented May 28, 2015

To clarify, here are the (significant) commits:

Added NanFatalException 81d4a2c

Introduce and use macros for disallowing assign, copy and move 3357130

Prohibit moving non-copyable classes fba4a29

Disallow assign, copy and move in _NanWeakCallbackInfo c96d9b2

Disallow assign, copy and move in NanCallback 4b808cb

Disallow assign, copy and move in NanAsyncWorker 1f55c59

Allow NanReturnValue(Persistent<T>) 915f155
In NAN 2.0, the equivalent will only work for Globals (previously known as UniquePersistents) due to upcoming changes in V8 4.5.

Deprecate NanGetPointerSafe and NanSetPointerSafe 3e60290

Deprecate NanBooleanOptionValue and NanUInt32OptionValue 0ad254b

Added more error types and made them all accept Handle<String> as arguments 4265f06
Needs doc update to list new error types.

Additionally, these could be backported from 'next':

Added indexed GetFromPersistent and SaveToPersistent 540d00d

Added SaveToPersistent(Handle<String>, ...) and GetFromPersistent(Handle<String>)
9891b2f

Added more tests for SaveToPersistent and GetFromPersistent 872f105

@kkoopa kkoopa added this to the 1.9 milestone May 28, 2015
@rvagg
Copy link
Member

rvagg commented May 30, 2015

great, looks like a changelog entry to me! do eeet!

@kkoopa
Copy link
Collaborator Author

kkoopa commented May 30, 2015

I'll probably have time today, yes. Think I'll do the backports too. That takes slightly longer.

@sam-github
Copy link
Contributor

Also added is dd87d9e, which I've been waiting to hit a release for baudehlo/node-fs-ext#48

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jul 31, 2015

1.9.0 is already released and this is mentioned in the changelog.

@sam-github
Copy link
Contributor

ah, great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants