Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Commit

Permalink
doc: update missing notes (#566)
Browse files Browse the repository at this point in the history
Closes: #557
Closes: #563
  • Loading branch information
MylesBorins committed Nov 4, 2020
1 parent ece6e6f commit ad736c3
Show file tree
Hide file tree
Showing 2 changed files with 83 additions and 0 deletions.
45 changes: 45 additions & 0 deletions doc/meetings/2020-10-07.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Node.js Modules Team Meeting 2020-10-07

## Links

* **Recording**: https://www.youtube.com/watch?v=Kgq08dm7kkM
* **GitHub Issue**: https://github.com/nodejs/modules/issues/557

## Present

* Modules team: @nodejs/modules

## Agenda

## Announcements

*Extracted from **modules-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/node

* esm: Modify ESM Experimental Loader Hooks [#34753](https://github.com/nodejs/node/issues/34753)

TL;DR: Geoffrey is working on a proposed redesign of loader hooks, including how they would work with different kinds of chaining use cases.


* Special treatment for package.json resolution and exports? [#33460](https://github.com/nodejs/node/issues/33460)

ljharb@ is working on it. Removing the label from upstream Issue.

### nodejs/modules

* Empty path matching in patterns [#553](https://github.com/nodejs/modules/issues/553)


* Enabling import meta resolve by default? [#550](https://github.com/nodejs/modules/issues/550)

Punted and label removed

* Mocking use cases [#549](https://github.com/nodejs/modules/issues/549)

Punted and label removed


* hot reload modules w/ es6 modules [#459](https://github.com/nodejs/modules/issues/459)

Punted and label removed
38 changes: 38 additions & 0 deletions doc/meetings/2020-10-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Node.js Modules Team Meeting 2020-10-21

## Links

* **Recording**: https://www.youtube.com/watch?v=tGosRXDqdRk
* **GitHub Issue**: https://github.com/nodejs/modules/issues/563

## Present

* Myles Borins (@MylesBorins)
* Geoffrey Booth (@GeoffreyBooth)
* Bradley Farias (@bmeck)
* Wesley Wigham (@weswigham)
* Jordan Harband (@ljharb)
* Doron Tsur(@qballer)

## Agenda

## Announcements

*Extracted from **modules-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/modules

* Experimental status [#564](https://github.com/nodejs/modules/issues/564)
* Separating out all the specific features
* Missing VM?
* Incomplete: no way yet to do the equivalent of `node --input-type=module --eval <string>` the way we can for CommonJS via vm.Script
* No hot module reload
* Gil found a hacky way to achieve this via query strings, but since we can’t remove modules from the ESM cache, this will lead to the Node process gradually using more and more memory the longer it’s running and a developer uses HMR (so basically it’s possible now but only with a memory leak)
* Instrumentation
* Missing chaining loaders, missing events for load ops
* separate package features (affect both CJS/ESM) from ESM itself?
*
* Empty path matching in patterns [#553](https://github.com/nodejs/modules/issues/553)



0 comments on commit ad736c3

Please sign in to comment.