src: Treat embeded builtins as V8 functions #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Node.js v12 most builtins are compiled during build time and embeded in the binary. Because of that, LLDB will think it knows how to handle these frames (especially JavaScript frames). To correctly handle those frames, we check the function name, if it starts with `Builtins_` we'll handle it as a JIT function. This method should be safe since any C++ function coming from V8 or Node.js will be mangled, thus beginning with `_Z...`. There might be a better way to handle this, but for now this check should be enough.
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 78.6% 78.89% +0.29%
==========================================
Files 33 33
Lines 4225 4227 +2
==========================================
+ Hits 3321 3335 +14
+ Misses 904 892 -12
Continue to review full report at Codecov.
|
|
cc @nodejs/llnode |
cjihrig
approved these changes
Oct 7, 2019
| @@ -69,7 +69,12 @@ bool BacktraceCmd::DoExecute(SBDebugger d, char** cmd, | |||
| const char star = (frame == selected_frame ? '*' : ' '); | |||
| const uint64_t pc = frame.GetPC(); | |||
|
|
|||
| if (!frame.GetSymbol().IsValid()) { | |||
| // TODO(mmarchini): There might be a better way to check for V8 builtins | |||
| // embeded in the binary. | |||
There was a problem hiding this comment.
Suggested change
| // embeded in the binary. | |
| // embedded in the binary. |
mmarchini
added a commit
that referenced
this pull request
Oct 7, 2019
On Node.js v12 most builtins are compiled during build time and embeded in the binary. Because of that, LLDB will think it knows how to handle these frames (especially JavaScript frames). To correctly handle those frames, we check the function name, if it starts with `Builtins_` we'll handle it as a JIT function. This method should be safe since any C++ function coming from V8 or Node.js will be mangled, thus beginning with `_Z...`. There might be a better way to handle this, but for now this check should be enough. PR-URL: #301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 2964af5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Node.js v12 most builtins are compiled during build time and embeded
in the binary. Because of that, LLDB will think it knows how to handle
these frames (especially JavaScript frames). To correctly handle those
frames, we check the function name, if it starts with
Builtins_we'llhandle it as a JIT function. This method should be safe since any C++
function coming from V8 or Node.js will be mangled, thus beginning with
_Z.... There might be a better way to handle this, but for now thischeck should be enough.