Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: teach llnode how to print Symbol properties names #214

Closed
wants to merge 2 commits into from
Closed

src: teach llnode how to print Symbol properties names #214

wants to merge 2 commits into from

Conversation

mmarchini
Copy link
Contributor

Still need to add the metadata to V8 before landing this.

Closes: #156

cjihrig

This comment was marked as off-topic.

Sign in to view

@mmarchini mmarchini changed the title [WIP] src: teach llnode how to print Symbol properties names src: teach llnode how to print Symbol properties names Dec 19, 2018
@mmarchini
Copy link
Contributor Author

Rebased, changed display format to Symbol()/Symbol('foo') and added code to fallback to <non-string> when Symbols metadata is not available (Node.js 6 and 8).

mmarchini pushed a commit that referenced this pull request Dec 21, 2018
@mmarchini
src: teach llnode how to print Symbol properties names
e30beba 
Closes: #156

PR-URL: #214
Fixes: #156
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@mmarchini
Copy link
Contributor Author

Landed in e30beba

@mmarchini mmarchini closed this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmarchini @cjihrig @joyeecheung