Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not create global llscan or global llv8 #170

Merged
merged 2 commits into from
Mar 10, 2018
Merged

src: do not create global llscan or global llv8 #170

merged 2 commits into from
Mar 10, 2018

Commits on Mar 9, 2018

  1. test: fix hanging when testing with prepared core 

    When the session is created by loading a prepared core dump,
it should delete the target before quitting otherwise the
process will prompt about deleting it and will hang if it
does not receive an answer.
    @joyeecheung
    joyeecheung committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    529b88a View commit details
    Browse the repository at this point in the history

  2. src: do not create global llscan or global llv8 

    - Eliminates all references to the global llscan in the commands,
  only instantiate one LLScan instance in llnode.cc and pass it
  down to all commands.
- Eliminates all references to the global llv8, store it inside
  the LLScan instead, because LLScan must need a valid llv8
  (with postmortem metadata loaded) to function.
- Only instantiate a static LLScan and a static LLV8 during plugin
  initialization.
    @joyeecheung
    joyeecheung committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    de84f75 View commit details
    Browse the repository at this point in the history