Skip to content

Commit

Permalink
test: disable flaky test for findrefs -s
Browse files Browse the repository at this point in the history
PR-URL: #244
Refs: #115
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
  • Loading branch information
mmarchini committed Mar 5, 2019
1 parent aad5414 commit c29d5af
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/plugin/scan-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,14 @@ function test(executable, core, t) {
sess.linesUntil(versionMark, (err, lines) => {
t.error(err);
t.ok(/Class_C\.arr/.test(lines.join('\n')), 'Should find parent reference with -r -n' );
sess.send('v8 findrefs -s "My Class C"');
// TODO(mmarchini) see comment below
// sess.send('v8 findrefs -s "My Class C"');
sess.send('v8 findjsinstances Zlib');
sess.send('version');
});

/* TODO(mmarchini) we need to fix
* https://github.com/nodejs/llnode/issues/267 before re-enabling this test
// Test for findrefs -s
sess.linesUntil(versionMark, (err, lines) => {
t.error(err);
Expand All @@ -138,6 +142,7 @@ function test(executable, core, t) {
sess.send('v8 findjsinstances Zlib');
sess.send('version');
});
*/

sess.linesUntil(versionMark, (err, lines) => {
t.error(err);
Expand Down

0 comments on commit c29d5af

Please sign in to comment.