-
Notifications
You must be signed in to change notification settings - Fork 131
Adds "releases" landing page, ties in to the /dist versions JSON #291
Conversation
Originally #287 but that was targeting the wrong branch. |
@Fishrock123 @therebelrobot I'll ping my two go-to build guys on this one. Functionally the release page is ready. Might need a cleanup / decision on the inclusion of the governance, working group pages (like, if we should link them, etc. or just remove from the "download" for now) before merging. |
If an agenda item cannot reach a consensus a TC member can call for | ||
either a closing vote or a vote to table the issue to the next | ||
meeting. The call for a vote must be seconded by a majority of the TC | ||
or else the discussion will continue. Simple majority wins. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
...
|
<div class="releaseTable-release"> | ||
<div class="releaseTable-versionRow"> | ||
<h2 class="releaseTable-version"> | ||
v1.5.1 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Resolved conflicts. As per @iojs/build this worked as expected. They pushed v1.6.2 and this code generated the page updates automatically as well as updating the new releases page. @iojs/website review? |
@@ -0,0 +1,445 @@ | |||
<!DOCTYPE html> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Any blockers @iojs/website ? |
This has been sitting over a week. Lots of eyes on the releases page as it was being using on a build test site and linked from other tickets. We can iterate on additional links, etc. as desired. |
For #284
Builds on #276 (PR is against that branch right now.) This page is auto-generated based on contents of https://iojs.org/dist/index.json - which is downloaded at the start of the
build
anddevelop
tasks. We're pulling from https://iojs.org/dist/index.json so the build team can automatically trigger site updates when a new version rolls out.The current (simple) layout to get the ball rolling.
I restructured the download task for multiple files. Added two external markdown files (governance, working-groups) which could be imported for automatic, up-to-date inclusion on the website.
If testing locally you'd see these downloaded files on /en/working-groups.html and /en/governance.html.
Outstanding question there: how to easily let the i18n groups import their own targets this way. Also, how do we let them point at external release notes, etc. (Unless we opt to include these in the site as well, which I am in favour of to keep things simple.)
Added a "Releases" link to the footer nav, for now.