Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-windows: python -m pip install packaging #213

Closed
wants to merge 4 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 18, 2023

@cclauss cclauss marked this pull request as draft October 18, 2023 13:48
@targos
Copy link
Member

targos commented Oct 18, 2023

Why is it needed suddenly?

@cclauss cclauss marked this pull request as ready for review October 18, 2023 23:12
@rzhao271
Copy link
Contributor

@cclauss PR LGTM, but I don't think it'll vendor the packaging package into the node-gyp npm package. the pip install --editable . line might also be installing the packaging package already, but pip can detect duplicate installs anyway, and listing out the packaging package seems clearer to me.

@targos node-gyp currently relies on distutils for detecting the Python version. Python 3.10 deprecates that package, and Python 3.12 removes distutils completely. The recommendation is to use the packaging package instead of distutils.version. Because node-gyp hasn't moved away from distutils yet, it is currently unusable on devices running Python 3.12.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 19, 2023

Agreed. I will get the vendoring done soon.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 20, 2023

I put this in DRAFT because I sense that we will close it with unmerged commits in favor of #214.

@cclauss cclauss closed this in #214 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants